-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of WFs for postEE scenario [12_4_X] #40138
Conversation
A new Pull Request was created by @sunilUIET (sunil bansal) for CMSSW_12_4_X. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Hi @sunilUIET |
Well, |
Hi @srimanob This PR is intended to use HLT :@relval2022_postEE for postEE relvals. This HLT key exists only in 12_4_X, therefore, we could not set it in 12_6_X for PR in master. |
But you can make a postEE wf in master using the postEE GT just with the 'HLTmenu': '@relval2022'! |
Thanks Martin for the suggestion! A PR 40151 is created for the master. |
Thanks @sunilUIET |
test parameters:
|
@cmsbuild please test |
Hi @srimanob We are getting different WF IDs for 12_6_X and 12_4_X. For TTbar process in 12_4_X use WF ID 13234 in place of 13634. |
@cmsbuild please abort |
Thx. I made a typo. I would like to run 13234.0 |
test parameters:
|
This is because 12_6_X also has the 2021FS workflows (from #38660): cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py Lines 27 to 28 in efd8199
If you want to keep the workflow numbers consistent, you can the range used by 2021FS in 12_6_X to the 12_4_X |
Pull request #40138 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again. |
Thanks @kpedro88 for the suggestion! PR is updated with the fix. |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13dc9d/29457/summary.html Comparison SummarySummary:
|
@perrotta @rappoccio Thanks. |
@cms-sw/orp-l2 , kind ping about this PR. #40138 (comment) and #40138 (comment) are still unanswered (#40138 (comment) is maybe a question to @cms-sw/pdmv-l2). |
|
Yes.
Okay. If you don't mind, please add "[12_4_X]" (or "[12_5_X]" or "[12_6_X]") somewhere in the title of each backport, so it's a bit easier to follow things. |
backport of #40151 |
Thanks! #40280 is created for backport in 12_5_X |
unhold |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to add WFs (IDs 13600.0 to 13943.0) with GT: phase1_2022_realistic_postEE and HLT: relval2022_postEE for the release validation for the post-EE scenario. The changes with this PR require merging of #39019 which includes post EE GT: phase1_2022_realistic_postEE. Newly added WFs already use the beam-spot as mentioned in #39019.
PR validation:
This PR is being tested with a few of the added WFs such as 13239, 13250, 13275.0
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is a backport #40151. The difference w.r.t. #40151 is that HLT keys are @relval2022_postEE in place of @relval2022.
@bbilin @kskovpen @francescobrivio @silviodonato